Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes in the Feature Scaling part in Day 1 code #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gap10
Copy link

@gap10 gap10 commented Sep 29, 2024

In the feature scaling part, I think we should not fit_transform the X_test. Rather, we should fit the StandardScaler on X_train and then transform the X_train and X_test. If I am wrong, please let me know.

@MirroZhou
Copy link

MirroZhou commented Sep 29, 2024 via email

@Cherrie52
Copy link

Cherrie52 commented Sep 29, 2024 via email

@wengJJ
Copy link

wengJJ commented Sep 29, 2024 via email

@dqhf
Copy link

dqhf commented Sep 29, 2024 via email

@bghfcd19900
Copy link

bghfcd19900 commented Sep 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants