Reader onboarding rsm - remove previously subscribed blogs from subscriptions modal, update some styles.#110547
Open
Addison-Stavlo wants to merge 12 commits intotrunkfrom
Open
Conversation
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Reader onboarding RSM “Discover/Subscribe” step to centralize recommendation selection/filtering logic in a dedicated hook, while adjusting modal layouts for improved responsiveness and spacing.
Changes:
- Introduces
useSubscribeRecommendationsto fetch, interleave, dedupe, weight, and filter blog recommendations (including excluding already-followed sites while keeping newly-subscribed items visible). - Updates the subscribe modal to consume the new hook, add site prefetching, and adjust loading/validation states.
- Tweaks responsive breakpoints/spacing in subscribe + interests modal styles and removes a duplicate curated blog entry.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| client/reader/onboarding-rsm/subscribe-modal/use-subscribe-recommendations.ts | New hook to build and validate recommendation lists, bridge feed data into Redux, and pin validated recommendations. |
| client/reader/onboarding-rsm/subscribe-modal/index.tsx | Refactors modal to use the new hook, prefetch site metadata, and adjust loading/pagination behavior. |
| client/reader/onboarding-rsm/subscribe-modal/style.scss | Adjusts responsive breakpoints to show/hide preview column at smaller widths. |
| client/reader/onboarding-rsm/interests-modal/style.scss | Reduces content padding to keep the “see more topics” link visible. |
| client/reader/onboarding-rsm/interests-modal/index.tsx | Adjusts VStack spacing to better fit the modal layout. |
| client/reader/onboarding-rsm/curated-blogs/society.tsx | Removes a duplicate curated blog entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd-subscriptions-shown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #
Proposed Changes
Updates the subscriptions shown in the subscription list to
Also updates some styles for the modals:
Why are these changes being made?
Testing Instructions
Pre-merge Checklist