Skip to content

Reader onboarding rsm - remove previously subscribed blogs from subscriptions modal, update some styles.#110547

Open
Addison-Stavlo wants to merge 12 commits intotrunkfrom
update/reader-onboarding-rsm-modal-tweaks-and-subscriptions-shown
Open

Reader onboarding rsm - remove previously subscribed blogs from subscriptions modal, update some styles.#110547
Addison-Stavlo wants to merge 12 commits intotrunkfrom
update/reader-onboarding-rsm-modal-tweaks-and-subscriptions-shown

Conversation

@Addison-Stavlo
Copy link
Copy Markdown
Contributor

@Addison-Stavlo Addison-Stavlo commented May 7, 2026

Part of #

Proposed Changes

Updates the subscriptions shown in the subscription list to

  • Not recommend blogs the user is already subscribed to, but also not to drop them from the list on subscribe.
  • Not jump/reorganize list after more items load.
  • Interleave curated blogs by tags, to prevent having too many neighbors of the same topic in the list.
  • Move the logic for the sites to its own helper/hook.

Also updates some styles for the modals:

  • Subscribe modal shows the preview stream column on smaller viewports where it was being hidden unnecessarily.
  • Interests modal spacing adjusted so "see more topics" link is visible at top scroll position in the modals full intended size.

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • For UI changes, have you tested the affected components in dark mode?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Addison-Stavlo Addison-Stavlo changed the title Update/reader onboarding rsm modal tweaks and subscriptions shown Reader onboarding rsm - remove previously subscribed blogs from subscriptions modal, update some styles. May 7, 2026
@Addison-Stavlo Addison-Stavlo marked this pull request as ready for review May 7, 2026 18:10
@Addison-Stavlo Addison-Stavlo requested a review from a team as a code owner May 7, 2026 18:10
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 7, 2026
@Addison-Stavlo Addison-Stavlo requested review from Copilot and removed request for a team May 7, 2026 18:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Reader onboarding RSM “Discover/Subscribe” step to centralize recommendation selection/filtering logic in a dedicated hook, while adjusting modal layouts for improved responsiveness and spacing.

Changes:

  • Introduces useSubscribeRecommendations to fetch, interleave, dedupe, weight, and filter blog recommendations (including excluding already-followed sites while keeping newly-subscribed items visible).
  • Updates the subscribe modal to consume the new hook, add site prefetching, and adjust loading/validation states.
  • Tweaks responsive breakpoints/spacing in subscribe + interests modal styles and removes a duplicate curated blog entry.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
client/reader/onboarding-rsm/subscribe-modal/use-subscribe-recommendations.ts New hook to build and validate recommendation lists, bridge feed data into Redux, and pin validated recommendations.
client/reader/onboarding-rsm/subscribe-modal/index.tsx Refactors modal to use the new hook, prefetch site metadata, and adjust loading/pagination behavior.
client/reader/onboarding-rsm/subscribe-modal/style.scss Adjusts responsive breakpoints to show/hide preview column at smaller widths.
client/reader/onboarding-rsm/interests-modal/style.scss Reduces content padding to keep the “see more topics” link visible.
client/reader/onboarding-rsm/interests-modal/index.tsx Adjusts VStack spacing to better fit the modal layout.
client/reader/onboarding-rsm/curated-blogs/society.tsx Removes a duplicate curated blog entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread client/reader/onboarding-rsm/subscribe-modal/index.tsx Outdated
Comment thread client/reader/onboarding-rsm/subscribe-modal/index.tsx Outdated
Comment thread client/reader/onboarding-rsm/subscribe-modal/use-subscribe-recommendations.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Comment thread client/reader/onboarding-rsm/subscribe-modal/use-subscribe-recommendations.ts Outdated
Comment thread client/reader/onboarding-rsm/subscribe-modal/index.tsx
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comment thread client/reader/onboarding-rsm/subscribe-modal/use-subscribe-recommendations.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@Addison-Stavlo Addison-Stavlo requested a review from Copilot May 7, 2026 21:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants