Skip to content

feat(newspack-icons): add typescript support; add new icons #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

feat(newspack-icons): add typescript support; add new icons #4088

wants to merge 1 commit into from

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented Jul 16, 2025 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This PR updates the newspack-icons to v1.0.1:

  • Support for TypeScript
  • 3 new icons: accessibility, browser, iframe

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. Make sure the icons still work
  3. Check typescript build

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot added the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 16, 2025
@thomasguillot thomasguillot marked this pull request as ready for review July 16, 2025 13:23
@thomasguillot thomasguillot requested a review from a team as a code owner July 16, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomasguillot