feat(ras-acc): add basic SVG handling? #3118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
I'm not sure we actually need this, but this PR takes a swing at consolidating all the SVGs used in the Newspack UI, and sets up a couple function to return or echo them.
This is a riff off of what's in the Newspack Theme, and might be overkill/clunky - it could also work to centralize and add on the individual functions that return the markup, like we're already doing in RAS-ACC -- open to feedback on that!
I haven't made any changes on the Newspack Blocks side yet; the duplication seems like an okay trade off for still having the SVGs work when the Newspack Plugin is disabled, but if this seems like a good plan we could do something similar there for the checkout-related SVGs.
How to test the changes in this Pull Request:
?ui-demo
and make sure the SVGs are loading.Other information: