Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update donation landing page #3109

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented May 13, 2024

All Submissions:

Changes proposed in this Pull Request:

This PR adds cover and columns blocks to the automatically generated donation page. Hopefully, it will enable publishers to be a bit more creative with this page, rather than the boring white page we were previously generating.

eg

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. Install newspack on a fresh site
  3. Run through the onboarding and go to the reader revenue wizard to save the donation page

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot added the [Status] Needs Review The issue or pull request needs to be reviewed label May 13, 2024
@thomasguillot thomasguillot self-assigned this May 13, 2024
@thomasguillot thomasguillot requested a review from a team as a code owner May 13, 2024 15:02
includes/class-donations.php Outdated Show resolved Hide resolved
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a file name change, other than that all good here.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 22, 2024
@thomasguillot thomasguillot merged commit 96218c1 into trunk May 22, 2024
7 checks passed
@thomasguillot thomasguillot deleted the update/donation-landing-page branch May 22, 2024 09:30
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 31, 2024
# [4.2.0-alpha.1](v4.1.0...v4.2.0-alpha.1) (2024-05-31)

### Bug Fixes

* **newsletters:** missing UTM params passing ([#3145](#3145)) ([0688fa0](0688fa0))
* **ras-setup:** redirect to init screen after setup ([#3142](#3142)) ([b86580b](b86580b))
* **ras:** handle RAS disabled in newsletters signup handling ([3d70a1d](3d70a1d))
* **ras:** prevent email address exposure via user login ([#3139](#3139)) ([9b534d3](9b534d3))
* **reader-revenue:** prevent sending duplicate receipt emails ([aa91890](aa91890))
* **tracking:** handling user role in pixel ([#3137](#3137)) ([a041764](a041764))

### Features

* **cli:** enable running the setup with a site import ([#3122](#3122)) ([c6cc10e](c6cc10e))
* expand memberships perf to archives ([#3148](#3148)) ([bdbdf1d](bdbdf1d))
* **memberships:** remove content restriction handling on the homepage ([b63a3fa](b63a3fa))
* update donation landing page ([#3109](#3109)) ([96218c1](96218c1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.0-epic-ia.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants