fix(model): ensure $isDeleted is set after calling doc.deleteOne() successfully

[vkarpov15]

Fix #15858

Summary

Using query.transform() instead of query.post() because Mongoose doesn't pass the result to query.post(), and adding the result to query.post() would be backwards breaking for cb-based post hooks.

Examples

[Copilot]

Pull request overview

This PR fixes an issue where doc.$isDeleted() was not being set to true after successfully calling doc.deleteOne(). The fix uses query.transform() to check the deletedCount property in the MongoDB result and sets $isDeleted(true) only when the deletion succeeds.

Key changes:

• Added query.transform() hook in Model.prototype.deleteOne() to set $isDeleted(true) when deletedCount > 0
• Added comprehensive tests covering successful deletion, failed deletion, and no-op behavior when already deleted

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
lib/model.js	Adds transform hook to set $isDeleted(true) after successful deleteOne operation
test/document.test.js	Adds tests verifying $isDeleted is set correctly after deleteOne, including success and failure cases

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[hasezoey]

LGTM, aside from what copilot brought up about the issue id in test name

[Neha-Sharmaaa]

Implemented in #16137

query.post() middleware now receives the query result as the first parameter.

Usage:

query.post(function(result) {
  if (result.deletedCount > 0) {
    // Handle successful delete
  }
});

Supported signatures:

• query.post(function() {}) - backward compatible, no params
• query.post(function(result) {}) - receives result
• query.post(function(result, next) {}) - receives result + next for async

Works with find(), findOne(), updateOne(), deleteOne(), and other query operations. Fully backward compatible.