Forms: fix 'Don't show this again' checkbox only dismissing on Got it click

[enejb]

Proposed changes

• Fix the "Don't show this again" checkbox in the Forms help modal ("Not seeing all your forms?") so that the permanent dismiss only fires when the user explicitly clicks "Got it", not when closing via the X button or Escape key.
• Previously, onRequestClose (X / Escape) shared the same handler as the "Got it" button, so checking the checkbox and then closing via X would permanently dismiss the modal with no way to undo.
• Now, closing via X or Escape simply closes the modal without side effects, allowing the user to change their mind.

Other information

The fix separates the modal's onRequestClose handler (which now just calls onClose) from the "Got it" button handler (renamed to handleSubmit), which checks the checkbox state before calling the dismiss API.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

Make sure that the option "jetpack_forms_classic_state" is set to "classic". This will make the button that shows the modal appear. You can do this in /wp-admin/options.php

1. Go to the Jetpack Forms dashboard on a site that has classic (non-managed) forms so the "Not seeing all your forms?" link appears.
2. Click the "Not seeing all your forms?" link to open the help modal.
3. Check the "Don't show this again" checkbox.
4. Close the modal by clicking the X button or pressing Escape.
5. Re-open the modal — it should still appear (the dismiss was NOT triggered).
6. Check the "Don't show this again" checkbox again.
7. Click the "Got it" button.
8. Verify the modal no longer appears — the dismiss was triggered only via "Got it".

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/forms-missing-forms-checkbox-dissmiss branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/forms-missing-forms-checkbox-dissmiss

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report