Settings: Align tab typography with WordPress design system tokens#47942
Settings: Align tab typography with WordPress design system tokens#47942
Conversation
Replace ad-hoc Jetpack CSS variables with WordPress design system tokens to match the @wordpress/ui Tabs component styling: - font-size: var(--font-body) to var(--wpds-font-size-md, 13px) - line-height: 1.5 to 1.2 - color: var(--jp-black) to var(--wpds-color-fg-interactive-neutral, #1e1e1e) - hover color: use var(--wp-components-color-accent) with admin theme fallback Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
Proposed changes
Align the Settings page tab navigation styling with the
@wordpress/uiTabs component by switching from ad-hoc Jetpack CSS variables to WordPress design system tokens.font-size:var(--font-body)tovar(--wpds-font-size-md, 13px)— matches the Tabs component's 13pxline-height:1.5to1.2— matches the Tabs component's tighter line-heightcolor:var(--jp-black)tovar(--wpds-color-fg-interactive-neutral, #1e1e1e)— proper foreground tokencolor: usevar(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9))— matches the accent color seen on the Tabs component in StorybookAll tokens include hardcoded fallbacks for contexts where the design token CSS custom properties aren't defined.
Before:

After:

Other information
This is a lightweight visual alignment step toward eventually adopting the
@wordpress/uiTabs component. No structural or behavioral changes — just typography tokens.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
jetpack build plugins/jetpackwp-admin/admin.php?page=jetpack#/settings)