Skip to content

Settings: Align tab typography with WordPress design system tokens#47942

Open
CGastrell wants to merge 1 commit intotrunkfrom
update/settings-tabs-font-alignment
Open

Settings: Align tab typography with WordPress design system tokens#47942
CGastrell wants to merge 1 commit intotrunkfrom
update/settings-tabs-font-alignment

Conversation

@CGastrell
Copy link
Copy Markdown
Contributor

@CGastrell CGastrell commented Apr 3, 2026

Proposed changes

Align the Settings page tab navigation styling with the @wordpress/ui Tabs component by switching from ad-hoc Jetpack CSS variables to WordPress design system tokens.

  • font-size: var(--font-body) to var(--wpds-font-size-md, 13px) — matches the Tabs component's 13px
  • line-height: 1.5 to 1.2 — matches the Tabs component's tighter line-height
  • color: var(--jp-black) to var(--wpds-color-fg-interactive-neutral, #1e1e1e) — proper foreground token
  • hover/focus color: use var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9)) — matches the accent color seen on the Tabs component in Storybook

All tokens include hardcoded fallbacks for contexts where the design token CSS custom properties aren't defined.

Before:
image

After:
image

Other information

This is a lightweight visual alignment step toward eventually adopting the @wordpress/ui Tabs component. No structural or behavioral changes — just typography tokens.

Related product discussion/links

  • Part of the Jetpack admin UI modernization / header standardization effort.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  1. jetpack build plugins/jetpack
  2. Navigate to Jetpack > Settings (wp-admin/admin.php?page=jetpack#/settings)
  3. Verify tabs render with consistent font sizing (13px, tighter line-height)
  4. Hover over tabs — text should shift to the accent/theme color
  5. Check mobile (≤ 660px) — tabs should still work in the dropdown

Replace ad-hoc Jetpack CSS variables with WordPress design system
tokens to match the @wordpress/ui Tabs component styling:

- font-size: var(--font-body) to var(--wpds-font-size-md, 13px)
- line-height: 1.5 to 1.2
- color: var(--jp-black) to var(--wpds-color-fg-interactive-neutral, #1e1e1e)
- hover color: use var(--wp-components-color-accent) with admin theme fallback

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/settings-tabs-font-alignment branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/settings-tabs-font-alignment

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu labels Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 3, 2026
@CGastrell CGastrell added [Status] Needs Review This PR is ready for review. Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Apr 3, 2026
@CGastrell CGastrell self-assigned this Apr 3, 2026
@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Coverage check overridden by Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Review This PR is ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant