Bump golang.org/x/sys from 0.0.0-20191026070338-33540a1f6037 to 0.1.0 in /jsonnet/tools/jsonnet-test #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
added 30 commits
October 19, 2020 19:43
Need to look at shared libraries as packages.
If a pipeline needs to be created multiple times, nest it.
Add basic docs. Add packaging examples. Add the ability to load 3rd party packages found in the `vendor` directory.
Add comment to fix code.
* move jsonnet specific logic into the correct package. * Change file system to a mockable FS for unit testing. * Unit test JsonnetRendering and custom share libraries. * Update Jenkins to actually test something. * Move save to a controller. Update TODO comments. * Apprently golang needs to create some cache files. * Maybe this may help with the checks. * Test `SavePipeline` using golang implicit interfaces. * Remove a possible issue. * Add comments.
Highlights: 1. Dependencies are now passed to controllers. 2. FS is no longer a singleton and is passed to every Service Provider (Project, Renderer, Backend) as a concrete requirement. 3. Tests are now truly decoupled thanks to the FS fix. 4. Minor fixes for large functions (decoupling functions to more concrete interactions) 5. Some renderer fixes, adding a custom Error type to handle missing libraries (a feature the shore-jsonnet-renderer implements) * Add support for render args file. The file may be either YAML or JSON, and properties will be pre-rendered in the JSONNET TLA level. This will remove the requirement to run parseJson on the JSONNET level for each run. * Update properties. * Fix nested unmarshal. The go standard library doesn't deal well with nested data structures. Jsoniter is a library that handles these cases with ease. Now the code can easily render any data structure and provide it as a TLA (top level argument) to the JSONNET VM. * Add comments. * Implement a project concept. Missing tests for the project. DI needs to be re-worked. * Add comment to `GetConfig*` methods for a shore-project. Fix Backend Interface naming to match Golang convetions. Fix `shore.go` commands. * Half state fix commit. Add dependecies to controllers. Move logic into controllers. Move Project specific behaviours out of the renderer. Fix tests. Add Project entity. Move project entity related tests FROM Renderer into Project. Fix Backend test. Start fixing renderer tests. * Make FS a concrete requirement and remove the Singleton pattern. Following this great blog post: https://testing.googleblog.com/2008/08/root-cause-of-singletons.html it seems like FS was a globallly mutable and caused problems due too that fact. This commit changes that. * Fix lazy loading of the SpinCli client by mocking the UI layer it using. Yes, that project wasn't designed very well. * Run client init only if it wasn't initialized beforehand.
Add the ability to execute pipelines via shore exec & shore exec --save/-s. The basic exec will just execute a pipeline, while --save/-s will save the pipeline before execution. * Implement basic exec functionality. Missing tests. * Fix API parameter names to match golang best practices. Add basic validation test for argument validation. * Add package `optional` required by swagger-code-gen (Spinnaker backend) * Remove redundant flag.
* full nested refactor + new tests for it * remove high level call to appvalidation backport renderer bugfix skip polling for existing pipeline after save update savePipeline tests add logging * address 's comments: add algorithm comment fix saveNestedPipeline stage indent var renames use errorlist length * add managed_infra example move/add comments cleanup * add simple pipeline test
* Redesign Execute command to return the correct value using a custom SpinCLI architecture. The current implementation of SpinCLI uses `swagger.yaml` to generate the client. This approach is appropriate, however the problem inhernt with ill designed swagger YAML are apparent at the API level. As an example, `inoke-pipeline` API route returns a response, however the client doesn't propogate this response in a good way. For these cases, a custom CLI that implements an HTTP interface to communicate with Spinnaker's Gate directly is appropriate. The choice to keep using SpinCLI for the easy cases (`SavePipeline` as an example) is too keep some of the features. In the future we may choose to break out of `SpinCLI` entirely. * Get basic pipeline execute & get pipeline exec details to work. * Most simple testing sync implementation without any bells and whistles. * Fix rendering and fix logging with `SilenceErrors`. * Multiple additions: Add support for output validation (spinnaker) Add TODOs Add tests for the `testing` logic. * Add testing for highlevel `TestPipeline` method. * Add a comment to exaplain the usage of `InitializeHttpClient`. * Add retry logic. * Add comment.
* Start adding logs everywhere! * Add logger. Pass logger to all required pieces. Already specified logger call sites. Support the `-v` syntax where each additional `v` adds a log level. Log level to param `-v` == 'Info' `-vvv` == 'Trace' Default is `Warn` (standard practice). * Fix backend tests. * Re-trigger PR
* Phase 1 terminology overview. * Typo and ennhancement fixes. * Update docs/internal/TERMINOLOGY.md Co-Authored-By: Jacob D'Onofrio <> * Use the better proposed terminology. * Add more data on shared libraries for JSONNET specifically. * Fix markdown link * Update TERMINOLOGY.md * Update terminology based on feedback. * Add diagram * Update TERMINOLOGY.md * Add a definition for `pipelines`. Co-authored-by: Jacob D'Onofrio <>
* Hide an intellij junk and binary output * Quick line describing the project * Merge DESIGN.md into README.md * Updated documentation * Rename section * Disclaimer about abstractions * Update README.md Update specifics Co-Authored-By: Eyal Mor <> * Update README.md Co-Authored-By: Eyal Mor <> * Update README.md Co-Authored-By: Eyal Mor <> * Remove misleading line * remove line Co-authored-by: Eyal Mor <>
Move to NullLogger in tests as recommended in the docs: https://github.com/sirupsen/logrus#testing
* Create the init function.
* Get a working init function.
* UX/UI fixes and a logical changes.
UX/UI:
1. Add a spinner when waiting for the `go` command to finish loading.
2. Add colored output for the `init` function.
Logical:
Change the dependency struct to depend on the `Project` instance.
The logic behind this change is there will always be one implementation of the `Project`. This is probably the only API that shore `core` requires. All other APIs are abstractions while this is the only concrenete implementation.
Another minor change is to make `params` default no matter what.
This means that running `shore render` with this file:
```
function(params)
{}
```
Will work without modification.
The reasoning is that we would like to make `params` a defacto standard in shore packages.
* Fix renderer tests and add a default to params.
* Refactor project init to be testable.
* Always add `require.go` file.
Validate libraries are required before creating a new `import` statement.
…rs` map. (#46) Given the way that Spinnaker is designed, the API parameters layer expects a scalar type for each parameter property. That means that: ``` {"parameters": {"abc": {"1": "2"}}} ``` is an ILLEGAL value and will result in a 400 response (failure) To counter this issue, the Spinnaker backend will recorgnize the `parameters` property and handle this case. For the previous object, the ExecutePipeline will transform the object into: ``` {"parameters": {"abc": "{\"1\": \"2\"}"}} ``` which is a stringified version of the json under the key `abc`. Additional changes are: 1. Switch to interfaces in the custom-cli. 2. Fix the ExecutePipeline test to return the request which can be used for validation. 3. Add extra test cases to validate the bug has been fixed in all possible manners.
* example nested pipeline jsonnet setup * nested 2x * use updated sponnet version * Update examples/managed_infra/main.pipeline.jsonnet * Update examples/managed_infra/main.pipeline.jsonnet Co-authored-by: Eyal Mor <>
* 1st PRD draft. * Update PRD.md * First fix batch. * Reorder and rephrase. * Update PRD.md Co-Authored-By: Simon Chammah <> * Apply suggestions from code review Co-Authored-By: Simon Chammah <> * Update PRD.md Co-Authored-By: Simon Chammah <> * Add collapsible element and rename the user story for a language migration developer lead. Signed-off-by: Eyal Mor <> * Add a clarification paragraph. * Remove BR, it's not needed on GH. Co-authored-by: Simon Chammah <>
* Add versioning, update Jenkinsfile and create a Makefile. * Fix Jenkins bug. * Remove un-necessary additional sub directory in artifactory target * Fix commit hash due to broken GIT integration in Jenkins. * Fix copy pasta bug * Fix missing library issue. * Add branch name to the artifact name and version. * Change version name to `local` when building without flags. Run make in parallel using the `-j 3` property. Use the internal go Proxy in `setup` command. * Update user, goproxy/goprivate and readme. * Prettify version building. * Try trimming. * Help artifactory understand the name without `/` (slashes). * Add release documentation.
* use default err behaviour * remove commented code * add test for missing pipeline file
* Use EvaluateAnonymousSnippet instead of the depracated EvaluateSnippet. * Re-introduce the local paths. * Fix tests to match new import of local directory. * Use custom importer to allow control of the chosen File System. * Update renderer.go
* Added file configuration * Added flag configuration * Added LoadSpecificConfig * Refactored configuration_Test * Matched error handling * Switched commands to using LoadSpecificConfig * Clean up commands now using LoadSpecificConfig * Removed configurator and tests * Comment * Added TestFlagWithBadJson * Changed LoadSpecificConfig to LoadCommandsConfig and updated its' unit tests * Updated use of LoadSpecificConfig to LoadCommandsConfig * Update pkg/config/configuration.go Co-authored-by: Eyal Mor <> * Update pkg/config/flags.go Co-authored-by: Eyal Mor <> * Update pkg/config/file.go Co-authored-by: Eyal Mor <> * Finished renaming functions. * fixes after merge from master * getConfigName and associated functions moved out of config and into command package * Moved getConfigName into shore * Making codacy happy * trying to make codacy even happier * Still trying to make codacy happy * This will surely appease the codacy gods Co-authored-by: Eyal Mor <>
* formatted * Added some test coverage * cleanup * Updated error messages
Add dependabot auto-update.
Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.8.1 to 1.9.0. - [Release notes](https://github.com/sirupsen/logrus/releases) - [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md) - [Commits](sirupsen/logrus@v1.8.1...v1.9.0) --- updated-dependencies: - dependency-name: github.com/sirupsen/logrus dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…sirupsen/logrus-1.9.0 Bump github.com/sirupsen/logrus from 1.8.1 to 1.9.0
Bumps [github.com/jsonnet-bundler/jsonnet-bundler](https://github.com/jsonnet-bundler/jsonnet-bundler) from 0.4.0 to 0.5.1. - [Release notes](https://github.com/jsonnet-bundler/jsonnet-bundler/releases) - [Changelog](https://github.com/jsonnet-bundler/jsonnet-bundler/blob/master/CHANGELOG.md) - [Commits](jsonnet-bundler/jsonnet-bundler@v0.4.0...v0.5.1) --- updated-dependencies: - dependency-name: github.com/jsonnet-bundler/jsonnet-bundler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.8.2 to 1.9.3. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.8.2...v1.9.3) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.4.0 to 1.6.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.4.0...v1.6.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Create release.yml * Make the actions work correctly. Co-authored-by: Eyal Mor <[email protected]>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.4 to 1.8.1. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.4...v1.8.1) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/google/go-jsonnet](https://github.com/google/go-jsonnet) from 0.18.0 to 0.19.1. - [Release notes](https://github.com/google/go-jsonnet/releases) - [Changelog](https://github.com/google/go-jsonnet/blob/master/.goreleaser.yml) - [Commits](google/go-jsonnet@v0.18.0...v0.19.1) --- updated-dependencies: - dependency-name: github.com/google/go-jsonnet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.0.0-20191026070338-33540a1f6037 to 0.1.0. - [Release notes](https://github.com/golang/sys/releases) - [Commits](https://github.com/golang/sys/commits/v0.1.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/go_modules/jsonnet/tools/jsonnet-test/golang.org/x/sys-0.1.0
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps golang.org/x/sys from 0.0.0-20191026070338-33540a1f6037 to 0.1.0.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.