Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to laravel v7 #935

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

quentincaffeino
Copy link
Contributor

@quentincaffeino quentincaffeino commented Jun 29, 2021

Went through laravel doc and updated laravel to v7.
https://laravel.com/docs/7.x/upgrade

Also added official cors extension for people like me who would need to setup api.

@quentincaffeino quentincaffeino changed the title upgraded laravel v7 Upgraded to laravel v7 Jul 4, 2021
@johannac johannac added the maintenance Maintenance and upgrades of code or dependencies label Jul 31, 2021
@MrPatrickHenry
Copy link

If this is working why not merge it?

@quentincaffeino
Copy link
Contributor Author

@MrPatrickHenry, project is almost dead to be honest, maintainers have very little time and there are not enough interest in the community in this project.

If you seriously interested in this project I suggest you to fork this project and do what you need to. You can merge any branches you wish and add any features. Of course it brings many complications with support but I'm afraid it is how it is.

@justynpride
Copy link
Contributor

It would be great to here from the project maintainers. In this last season I know many in the event industry have had to find other work as there has been no work in events. I therefore have much understanding for a shift in focuses. With events opening up again, I can see a real need for systems like this to be continually updated and developed. I've researched a number of open source systems and this is one of the more intuitive ones, and I love that it is built on Laravel.

That said it would be helpful to know if the project has life, and how others can be involved.

@johannac
Copy link
Member

That's pretty much the crux of it all Justyn.. I am the only current active maintainer of the 4. Our business, an events management company, was funding this project until COVID hit last year and we've not been able to run any events or make any revenue to fund software development here. I had to take a full time job in a different industry and as such am only working on Attendize in my spare time, while also trying to revive our events. We really love and care about this project, and we are trying to keep it limping along until we recover from the impact of COVID on the industry.

That said, most of the big upgrades, like Laravel v7, Composer v2, PHP8, or big new features like the roles and permissions system, get somewhat stalled because the code in this application is so old and brittle. There's almost no tests and it's nearly impossible to guarantee an upgrade or new feature actually works. I know a fair amount of people use this project, and I want to be cautious about what gets rolled out, to the best of my abilities.

My aim is to roll a new release once per month. I tend to favour bug fixes and refactoring over upgrades and new features, because they're less risky but still provide value. I know there are quite a few project followers, such as yourselves, who use this software very actively and are keen to get new features and upgrades rolled out. And I greatly appreciate all your contributions, testing and feedback on the project.

I can commit to merging and rolling out an upgrade or new feature once every 2 months or so, from the stuff that's submitted in PRs. The more input, feedback and testing everyone can provide, the better and more stable the releases will be. Just myself testing changes isn't enough. We need to test different operating systems, different versions, different set ups.

@justynpride
Copy link
Contributor

justynpride commented Aug 22, 2021

@johannac Thanks for your really helpful update. I can completely appreciate your situation. I have a separate booking system that handles more complex ticketing events, and I've had no clients during Covid. I'd like to replace it with Attendize, but there is a lot of development work needed for that, and I've been hesitant not knowing what future Attendize had.

To know that there is interest still in the project is very helpful. I can see from a few posts how some contributors have almost given up on contributing to the project. To know that you are wanting to move the project forwards is very helpful, and I trust encourages others to keep making contributions, and even start making pull requests for some of their custom developments.

I've not encountered another ticketing system that I like as much for the general interface and basic functionality of. It is quite intuitive and clean, which is always something I prioritize!

I can definitely aid with testing, and will look to see how else I can help.

@justynpride
Copy link
Contributor

@quentincaffeino Just a huge thank you for this pull request. I've just been using it with a fresh install and also using your composer2 pull request. A fully successful install! From what I've seen on my testing of every button push it works fully as I would expect.

fix: add cors default config
feat: move cors middleware to global middlewares because 1. it is done so in laravel framework, 2. it is made so so person can specify paths where cors is applied via config
fix: update key for default mailer in mail config, update docs from official source code
@justynpride
Copy link
Contributor

@quentincaffeino I’ve not really had much of a look, but are there any main differences between this and #778? Was it just preference over manual update, rather than Laravel Shift?

@quentincaffeino
Copy link
Contributor Author

@justynpride

At the time I didn't notice that there is already a pr for this

@justynpride
Copy link
Contributor

@quentincaffeino Thanks. That makes a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance and upgrades of code or dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants