-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using util.angle_mod in all codes. #684 #946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for PR.
Please fix CI error first:
=================================== FAILURES ===================================
_____________________________________ test _____________________________________
[gw3] linux -- Python 3.11.6 /opt/hostedtoolcache/Python/3.11.6/x64/bin/python
def test():
branch_commit = find_branch_point("origin/master")
files = diff_files(branch_commit)
print(files)
rc, errors = run_ruff(files, fix=True)
if errors:
print(errors)
else:
print("No lint errors found.")
> assert rc == 0
E assert 1 == 0
branch_commit = '0dc6ab42bab4d3e2fb06fc[25](https://github.com/AtsushiSakai/PythonRobotics/actions/runs/7062067522/job/19257122187?pr=946#step:6:26)d86b1abe41d4da2a'
errors = 'Control/move_to_pose/move_to_pose.py:181:15: UP0[31](https://github.com/AtsushiSakai/PythonRobotics/actions/runs/7062067522/job/19257122187?pr=946#step:6:32) Use format specifiers instead of percent format\nControl/move_to_p...errors (9 fixed, 3 remaining).\nNo fixes available (3 hidden fixes can be enabled with the `--unsafe-fixes` option).\n'
files = ['/home/runner/work/PythonRobotics/PythonRobotics/ArmNavigation/n_joint_arm_to_point_control/n_joint_arm_to_point_cont...'/home/runner/work/PythonRobotics/PythonRobotics/PathPlanning/ModelPredictiveTrajectoryGenerator/motion_model.py', ...]
rc = 1
Fixed the CI errors as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. I have some recommendations. PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for long discussion with me!!
fix #684
As suggested in the issue, searched for instances for wrapping an angle between -pi to pi and modified the code to use util.angle_mod. Searched .pi throughout all the files to identify lines where angle_mod() is implemented again.
Summary of instances found:
I hope this helps in review.
I am new to OSS contributions, please let me know if I am missing anything. Thanks for bearing with me! ^_^
CheckList