-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of velocity scale factor estimation to EKF #937
Conversation
Hi, thank you for great PR!! |
Thank you for your suggestion. |
Thank you. Is it possible to update this doc to explain your code too? |
OK, I will do that. |
@AtsushiSakai |
I'm sorry for my late reply. @rsasaki0109 You can do grouping the "Filter design", "Motion model", "Observation model" for only position estimation and your position and velocity estimation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only remaining comment is for doc structure.
@rsasaki0109 Hi. Is it possible to finish this PR? Only remaining task is just organizing docs. If it is difficult for you, I can do it. Let me know. Thanks for good PR. |
@AtsushiSakai (Note: Since I couldn't do it last weekend, I will do it in my free time...). |
@AtsushiSakai ex)
|
Yes. I think other two “filter design” and “Extended Kalman Filter” are common. |
sorry, is it possible to merge the latest master code to build doc in CI? @rsasaki0109 |
...ation/extended_kalman_filter_localization_files/extended_kalman_filter_localization_main.rst
Outdated
Show resolved
Hide resolved
…files/extended_kalman_filter_localization_main.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!! @rsasaki0109
I'm sorry, I've been a bit busy this month and my response was delayed... |
What does this implement?
I have added velocity scale factor estimation to
extended_kalman_filter.py
.This is for correcting the vehicle speed measured with scale factor errors due to factors such as wheel wear.
Additional information
I have adjusted the noise for velocity scale factor estimation, as it was not well-estimated with the default parameters.
It is assumed that the GNSS is RTK FIXed.
CheckList