Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of velocity scale factor estimation to EKF #937

Merged
merged 14 commits into from
Jan 22, 2024
Merged

Addition of velocity scale factor estimation to EKF #937

merged 14 commits into from
Jan 22, 2024

Conversation

rsasaki0109
Copy link
Contributor

@rsasaki0109 rsasaki0109 commented Nov 19, 2023

What does this implement?

I have added velocity scale factor estimation to extended_kalman_filter.py.
This is for correcting the vehicle speed measured with scale factor errors due to factors such as wheel wear.

ekf_animation

Additional information

I have adjusted the noise for velocity scale factor estimation, as it was not well-estimated with the default parameters.
It is assumed that the GNSS is RTK FIXed.

CheckList

  • Did you add an unittest for your new example or defect fix?
  • Did you add documents for your new example?
  • All CIs are green? (You can check it after submitting)

@AtsushiSakai
Copy link
Owner

Hi, thank you for great PR!!
Is it possible to add a new script for it, not modify the current file?

@rsasaki0109
Copy link
Contributor Author

Thank you for your suggestion.
I've now added the new script ekf_with_velocity_correction.py to the Localization/extended_kalman_filter directory, which introduces the velocity correction feature for EKF.
Does this look good to you?

@rsasaki0109 rsasaki0109 marked this pull request as ready for review November 20, 2023 12:33
@AtsushiSakai
Copy link
Owner

Thank you. Is it possible to update this doc to explain your code too?

@rsasaki0109
Copy link
Contributor Author

OK, I will do that.

@rsasaki0109
Copy link
Contributor Author

@AtsushiSakai
I have added the document. Is this the correct way to add it?

@AtsushiSakai
Copy link
Owner

AtsushiSakai commented Dec 18, 2023

I'm sorry for my late reply. @rsasaki0109
For document, I think it is better to modify this file https://github.com/AtsushiSakai/PythonRobotics/blob/master/docs/modules/localization/extended_kalman_filter_localization_files/extended_kalman_filter_localization_main.rst
instead of adding new docs.

You can do grouping the "Filter design", "Motion model", "Observation model" for only position estimation and your position and velocity estimation.
image

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only remaining comment is for doc structure.

@AtsushiSakai
Copy link
Owner

@rsasaki0109 Hi. Is it possible to finish this PR? Only remaining task is just organizing docs. If it is difficult for you, I can do it. Let me know. Thanks for good PR.

@rsasaki0109
Copy link
Contributor Author

rsasaki0109 commented Jan 11, 2024

@AtsushiSakai
Sorry, I didn't notice your comment. I'll work on it. Probably this weekend.

(Note: Since I couldn't do it last weekend, I will do it in my free time...).

@rsasaki0109
Copy link
Contributor Author

rsasaki0109 commented Jan 21, 2024

@AtsushiSakai
Is your comment meant to mean this?

ex)

  • Motion Model

    • only position estimation
    • position and velocity estimation
  • Observation model

    • only position estimation
    • position and velocity estimation

@AtsushiSakai
Copy link
Owner

AtsushiSakai commented Jan 21, 2024

Is your comment meant to mean this?

Yes. I think other two “filter design” and “Extended Kalman Filter” are common.
@rsasaki0109

@AtsushiSakai
Copy link
Owner

AtsushiSakai commented Jan 21, 2024

sorry, is it possible to merge the latest master code to build doc in CI? @rsasaki0109

…files/extended_kalman_filter_localization_main.rst
Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!! @rsasaki0109

@AtsushiSakai AtsushiSakai merged commit cfe1e30 into AtsushiSakai:master Jan 22, 2024
7 of 8 checks passed
@rsasaki0109
Copy link
Contributor Author

rsasaki0109 commented Jan 22, 2024

I'm sorry, I've been a bit busy this month and my response was delayed...
Thank you for your assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants