BREAKING CHANGE: Unify Math & Mathf. Make every method in Math polymorphic #2335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we're doing several breaking changes:
std/util/math
NativeMath#scalebn
NativeMath#rem
NativeMath#mod
(but not tests)NativeMathf
completelyMath.random
(forf64
type)Caveats:
Before this PR this will create unnecessary cast to f64,
Math.floor
and downcast toi32
. With this PR this code now equivalent tox / y
without all this unnecessary work due toMath.floor
,Math.trunc
and etc accept integers and pass through it "as is".This is the most painful caveat, which can lead to many breaking changes in some code.
Perhaps we could add new generic builtin helper which forces parameter type to float. Something like:
Thoughts?