Support not running as root #24
Open
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davide125
reviewed
Mar 1, 2025
| @@ -4,6 +4,9 @@ Description=Speaker Protection Daemon | |||
| [Service] | |||
| Type=simple | |||
| ExecStart=/usr/bin/speakersafetyd -c /usr/share/speakersafetyd/ -b /var/lib/speakersafetyd/blackbox -m 7 | |||
| User=speakersafetyd | |||
There was a problem hiding this comment.
It might make sense to use DynamicUser for this, so distributions won't have to manage yet another static service user. Something like:
DynamicUser=yes
User=speakersafetyd
Group=speakersafetyd
RuntimeDirectory=/run/speakersafetyd
StateDirectory=/var/lib/speakersafetyd
(completely untested to be clear)
There was a problem hiding this comment.
Nay on dynamic user, speakersafetyd generates a "blackbox" file on crash, and services using dynamic user are not supposed to leave non-temporary files on exit.
We don't need to be running as root. Let's run as speakersafetyd by default. Signed-off-by: James Calligeros <[email protected]>
|
Thanks a lot! I've been running like so for some time on my Void machine, and it works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to be running as root. Let's run as speakersafetyd by default.