Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.3.4.1 release #121

Merged
merged 1 commit into from
Mar 28, 2024
Merged

V1.3.4.1 release #121

merged 1 commit into from
Mar 28, 2024

Conversation

tpcarman
Copy link
Contributor

Related Issue

Fixed

Motivation and Context

  • Improve VSAN support

How Has This Been Tested?

  • VxRail environments with ESA and OSA

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

### Fixed
- Add VSAN ESA support ([Fix #113](#113))
Copy link

PSScriptAnalyzer results:

Errors: [0], Warnings: [10], Information: [16]


RuleName   : PSUseSingularNouns
Severity   : Warning
ScriptName : Get-vCenterStats.ps1
Line       : 1
Message    : The cmdlet 'Get-vCenterStats' uses a plural noun. A singular noun 
             should be used instead.

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-RequiredModule.ps1
Line       : 18
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-RequiredModule.ps1
Line       : 22
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSAvoidOverwritingBuiltInCmdlets
Severity   : Warning
ScriptName : Get-Uptime.ps1
Line       : 1
Message    : 'Get-Uptime' is a cmdlet that is included with PowerShell (version 
             core-6.1.0-windows) whose definition should not be overridden

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-Uptime.ps1
Line       : 6
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 35
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 38
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 59
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 81
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 109
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 42
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 47
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 54
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 78
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-Uptime.ps1
Line       : 9
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 35
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 39
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 47
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 55
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 56
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 60
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 72
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 77
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 82
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 100
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 108
Message    : Line has trailing whitespace

@tpcarman tpcarman merged commit be30ac4 into master Mar 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant