Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.4 Release Candidate 1 #117

Merged
merged 17 commits into from
Dec 1, 2023
Merged

v1.3.4 Release Candidate 1 #117

merged 17 commits into from
Dec 1, 2023

Conversation

tpcarman
Copy link
Contributor

@tpcarman tpcarman commented Dec 1, 2023

v1.3.4 Release Candidate 1

Description

Many changes were made with VMware vSphere 8.x, which resulted in numerous issues with the VMware vSphere As Built Report. Many of these issues we hope to address in this release candidate.

Related Issue

Changed

  • Updated VMware PowerCLI requirements to version 13.2 (Fix #107)
  • Improved bug and feature request templates (@rebelinux)
  • Improved TOC structure
  • Updated VMware style script for improved TOC structure

Fixed

  • Updated VMHost PCI Devices reporting to fix issues with ESXi 8.x hosts (@orb71) (Fix #105) & (Fix #111)
  • Added Try/Catch stated PCI Drivers and Firmware section to provide a workaround for ESXi 8.x hosts (Fix #116)
  • Updated vCenter Server alarms reporting (Fix #106)
  • Fixed issue with Platform Services Controller reporting (Fix #103)

Removed

  • Removed reporting of vCenter Server OS type

Motivation and Context

Provide support for VMware vSphere 8.x environments.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

tpcarman and others added 17 commits April 22, 2022 09:27
- Add testing of module manifest to PS Gallery workflow
- Add PS Gallery workflow dependency for tweet action
- Fix display issues with highlights in `README.md`
Rewrite of 'ESXi Host PCI Devices'
Improved bug and feature request templates.
### Changed
- Updated VMware PowerCLI requirements to version 13.2
- Improved bug and feature request templates
- Improved TOC structure
- Updated VMware style script for improved TOC structure

### Fixed
- Updated VMHost PCI Devices reporting to fix issues with ESXi 8.x hosts ([Fix #111](#111))
- Added Try/Catch stated PCI Drivers and Firmware section to provide a workaround for ESXi 8.x hosts ([Fix #116](#116))
Copy link

github-actions bot commented Dec 1, 2023

PSScriptAnalyzer results:

Errors: [0], Warnings: [10], Information: [16]


RuleName   : PSAvoidOverwritingBuiltInCmdlets
Severity   : Warning
ScriptName : Get-Uptime.ps1
Line       : 1
Message    : 'Get-Uptime' is a cmdlet that is included with PowerShell (version 
             core-6.1.0-windows) whose definition should not be overridden

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-Uptime.ps1
Line       : 6
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 35
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 38
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 59
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 81
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : Get-License.ps1
Line       : 109
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-RequiredModule.ps1
Line       : 18
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSUseProcessBlockForPipelineCommand
Severity   : Warning
ScriptName : Get-RequiredModule.ps1
Line       : 22
Message    : Command accepts pipeline input but has not defined a process block.

RuleName   : PSUseSingularNouns
Severity   : Warning
ScriptName : Get-vCenterStats.ps1
Line       : 1
Message    : The cmdlet 'Get-vCenterStats' uses a plural noun. A singular noun 
             should be used instead.

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-Uptime.ps1
Line       : 9
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 35
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 39
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 47
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 55
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 56
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 60
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 72
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 77
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 82
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 100
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-License.ps1
Line       : 108
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 42
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 47
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 54
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : Get-PciDeviceDetail.ps1
Line       : 78
Message    : Line has trailing whitespace

@tpcarman tpcarman merged commit 5682b93 into master Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants