[pull] master from curl:master #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
- Prefer Sleep(1) over sched_yield() for pre-Vista thread yield. On Windows sched_yield is often implemented as Sleep(0) which only yields to threads of highest priority to current priority. However, during libcurl initialization if there is thread contention then it's possible that there is a wait for a different library or OS thread of a lesser priority and then the yield is not effective during that time. On the other hand Sleep(1) will wait the minimum time slice which is usually like 15ms or more. Prior to this change 2c4bfef removed sched_yield detection on Windows, which effectively removed the yield in the spin lock, and therefore this change restores the yield but in a different way. For Windows Vista and later we use SRW locks and do not have this issue. Ref: #16037 (comment) Ref: https://devblogs.microsoft.com/oldnewthing/20051004-09/?p=33923 Closes #16048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )