Address hdr_histogram issues #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ceil/floor compatibility with pre OTP 20 versions
- No named table even for concurrent access
The table id is stored in the #hist{} struct (which is shared with all
updating processes) anyway, so no need for a registered name. This is
a minor optimisation to avoid name->tid lookup. (Working with tids was
slightly optimised in OTP 20 when they became references instead of
integers)
- One table and one entry per histogram
Create one table and one entry when initialising the histogram.
Delete the whole table when deleting the histogram.
Compatibility with hdr_histogram_erl NIF
- Use erlang:make_tuple when reseting row
This avoids creating a huge temporary list. Reset is called relatively
infrequently, so this change does not have too big impact.
- OPT: calculate bucket/subbucket index from index
- Collect multiple stats in single iteration
Store pid/regname of event handler process in application env.
A message in the form `{snapshost, NowTime}` is sent to the event
handler when a snaphost is created.
The testcases subscribe themselves as event handlers making them
synchornous and bit less prone to timing issues.
So far this is only used for tests but could be the start of a
websocket-based notification system.
natif
approved these changes
Feb 6, 2019
berespt
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It already contains some fixes missing from our fork
As the Erlang version is somewhat slower (not measured precisely) the NIF is the default
fixes #86