Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AE2 New Textures #7870

Merged
merged 20 commits into from
Jun 14, 2024
Merged

AE2 New Textures #7870

merged 20 commits into from
Jun 14, 2024

Conversation

Ridanisaurus
Copy link
Contributor

This PR includes:

  • Item Textures
  • Block Textures
  • Block Models
  • Render Code Changes
  • GUIs

Copy link
Contributor

@Mithi83 Mithi83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little feedback, mainly about lingering comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few TODO comment here, also some commented out old code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few TODO comment here, also some commented out old code.

src/main/java/appeng/client/gui/WidgetContainer.java Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are several commented out infoBar.addSpace() calls that have different values than before. I guess they can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept these in case Devs would like to revert back some of the changes, or review what has been removed.

@@ -107,23 +107,24 @@ public class ColorApplicatorItem extends AEBasePoweredItem
Function.identity()));
private static final BiMap<DyeColor, Item> VANILLA_DYES = EnumHashBiMap.create(DyeColor.class);

// TODO (RID): Sorted the colours according to the colour wheel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment could be removed.

@RuiXuqi
Copy link

RuiXuqi commented May 19, 2024

Since the changes are so big, could we have a built in resourcepack of the old textures?

@Ridanisaurus
Copy link
Contributor Author

Since the changes are so big, could we have a built in resourcepack of the old textures?

As you can see, these are more than just texture changes. Having a resource pack of the old textures won't be possible with a lot of additional work to accommodate all the new record code, new icons, new GUI elements ..etc.

If someone wants to spend the time and work on it, then be my guest. I personally don't see a reason why would anyone wants to use the old textures when the new textures are more refined.
I understand that the Light Mode is not for everyone, and it is such a drastic change. This is why I'm gonna be working on a Dark Mode version of the textures as a Texture Pack, but I won't port forward the old textures.

@shartte shartte merged commit 3735739 into AppliedEnergistics:main Jun 14, 2024
1 check passed
@MikoTheBoi
Copy link

MikoTheBoi commented Jun 18, 2024

I have to be honest and say that if you can't backport the original textures this will really be the worst update ae2 has ever had. This could've been a texture pack. You didn't have to replace the in my opinion better textures with this.

@Leclowndu93150
Copy link

true

@Ridanisaurus
Copy link
Contributor Author

I have to be honest and say that if you can't backport the original textures this will really be the worst update ae2 has ever had. This could've been a texture pack. You didn't have to replace the in my opinion better textures with this.

It couldn't have been a texture pack, no. There are multiple render code changes. Also, if you don't like the textures, please feel free to make your own texture pack.

@MikoTheBoi
Copy link

Would there be many issues if I just replace all the newer textures with the older ones?

@RuiXuqi
Copy link

RuiXuqi commented Jun 18, 2024

Would there be many issues if I just replace all the newer textures with the older ones?

Yes. Because this pr not only changes the textures but also changes the models, gui render methods and colour codes, which means a resource pack can't port all of the old textures back

@MikoTheBoi
Copy link

Yes, but ignoring the guis and such would all the blocks look ok?

@RuiXuqi
Copy link

RuiXuqi commented Jun 18, 2024

Yes, but ignoring the guis and such would all the blocks look ok?

Most of them would be, but the terminals use colour codes, which are difficult to change.

@Leclowndu93150
Copy link

https://www.curseforge.com/minecraft/texture-packs/applied-energistics-2-programmers-art

@MikoTheBoi
Copy link

Oh wow that was fast, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants