Fix crafting job progress bar exceeding 100% #7839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a progress bar rendering more than the maximum width by clamping the percentage if the crafting job makes heavy use of non-consumed items. Note that this is merely a cosmetic fix for an overly long progress bar. The bar will still reach 100% much faster than completing the job. This is a more fundamental issue that still needs to be fixed separately. Partial fix for AppliedEnergistics#7468.
|
Yeah I'd rather fix the underlying problem and then apply this as a last-resort fix for the rendering |
|
Superseded by #8005. I decided to not include this visual fix in the new approach to allow future bugs to be visible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a progress bar rendering more than the maximum width by clamping the percentage if the crafting job makes heavy use of non-consumed items.
Note that this is merely a cosmetic fix for an overly long progress bar. The bar will still reach 100% much faster than completing the job. This is a more fundamental issue that still needs to be fixed separately.
Partial fix for #7468.
Note that I could not in fact verify that it does no longer occur, because I have no setup with mods using non-consumed items. I still think that a cosmetic fix is better than nothing.