Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .gitignore entries that weren't being parsed. Fix inconsistent indenting and whitespace. #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgreenemi
Copy link

Hey there - while reading through the code I kept tripping over spacing inconsistencies that made it distracting to read through. I've updated spacing and indenting to be consistent with the PEP8 standard. The logic of the code remains unchanged. I did not review the contents of code cells in the Jupyter notebook for formatting inconsistencies.

Also, the .gitignore looked to have been copied in from somewhere that introduced a preceding - string to each line (aside from the custom lines at the bottom), rendering the entries unusable. I've fixed these lines so now virtualenv directories, compiled Python files, etc. will not be included in future git commits. I did take the liberty of adding an Intellij-specific ignore rule for the .idea/ preferences directory as is standard practice.

Do let me know if I can answer any questions, or if splitting this into separate PRs will help given that the size of the change is not trivial.

All the best,
Joe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant