Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/thrift 5682 cherry picked from tinloaf cpp move to implementation #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Feature/thrift 5682 cherry picked from tinloaf cpp move to implementation #13

wants to merge 6 commits into from

Conversation

bsergean
Copy link
Collaborator

@bsergean bsergean commented Apr 4, 2023

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

bsergean and others added 6 commits April 4, 2023 16:02
@bsergean
document current only change
0c243f0
@tinloaf @bsergean
Move default constructor and operator== implementation to CPP file
7bca054 
Both the default constructor and operator== implementations reference
certain member functions of the class' members. As an example, the default
constructor references (i.e., "uses") the default constructors of its
members.

If a class contains a std::vector<Foo>, and Foo has only been *forward*-
declared (which happens often in Thrift-generated code), this creates
undefined behavior: The std::vector specification states that as long as
Foo is an incomplete type, it is fine to reference std::vector<Foo>, but
not any members (such as its default constructor).

Thus, we must defer our default constructor's implementation (which references
the default constructor of std::vector<Foo>) to a point where Foo is a
complete type. That is the case in the .cpp file.

The same holds for operator==.
@tinloaf @bsergean
Factor out duplicated code into helper function
b5723ab
@tinloaf @bsergean
Move generate_default_constructor call into generate_struct_definition
bc560a7 
This makes sure that helper structs like _args and _result also have
their default constructors defined.
@tinloaf @bsergean
Always generate an initializer list
b32976e
@tinloaf @bsergean
Fix ODR violations in cases where templates are involved
c378d51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsergean @tinloaf