Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document to PDF feature for AppFlowy Editor #695

Merged
merged 27 commits into from
Jul 4, 2024
Merged

Document to PDF feature for AppFlowy Editor #695

merged 27 commits into from
Jul 4, 2024

Conversation

rileyhawk1417
Copy link
Contributor

@rileyhawk1417 rileyhawk1417 commented Jan 28, 2024 •
edited
Loading

This PR is an initial draft for the feature to provide a built-in converter that can convert from Markdown to PDF.
The feature is using some code from htmltopdfwidgets as reference.

Checklist

  • Support Checkboxes.
  • Support Images in document.
  • Coloured text/Highlighted text.
  • Render Tables(partially supported)

Whats supported

  • Basic Text
  • Bullet Lists.
  • Todo List/Checklist
  • Emoji Fonts.

The todo items may change overtime depending on the requirements of the feature.
When its ready will mark this PR as ready.

@rileyhawk1417 rileyhawk1417 mentioned this pull request Jan 30, 2024
Closed
@rileyhawk1417
Copy link
Contributor Author

rileyhawk1417 commented Feb 7, 2024 •
edited
Loading

This PR is meant to target Document type for exports, also addressing the following issue #3264 #2938

@rileyhawk1417
Copy link
Contributor Author

@LucasXu0 & @Xazin am working on table support now, will mark it as ready when am done. Then open another PR for writing the tests.

@codecov Codecov
Copy link

codecov bot commented Mar 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 303 lines in your changes missing coverage. Please review.

Project coverage is 73.24%. Comparing base (37432ea) to head (77a3bf4).
Report is 1 commits behind head on main.

Files Patch % Lines
lib/src/plugins/pdf/html_to_pdf_encoder.dart 0.00% 275 Missing ⚠️
lib/src/plugins/pdf/extension/color_ext.dart 0.00% 28 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   74.80%   73.24%   -1.56%     
==========================================
  Files         313      315       +2     
  Lines       14264    14567     +303     
==========================================
  Hits        10670    10670              
- Misses       3594     3897     +303

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rileyhawk1417 rileyhawk1417 changed the title Draft: Document to PDF feature for AppFlowy Editor Document to PDF feature for AppFlowy Editor Mar 16, 2024
@rileyhawk1417
Copy link
Contributor Author

Have added table support. Will open another PR to handle the tests.

@rileyhawk1417 rileyhawk1417 marked this pull request as ready for review March 16, 2024 12:10
@LucasXu0 LucasXu0 added the v3.1.0 label Jul 4, 2024
@LucasXu0 LucasXu0 merged commit f6ee2fc into AppFlowy-IO:main Jul 4, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rileyhawk1417 @LucasXu0