-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title Node Plugin For AppFlowy Editor #392
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 80.41% 80.84% +0.42%
==========================================
Files 281 253 -28
Lines 11863 10331 -1532
==========================================
- Hits 9540 8352 -1188
+ Misses 2323 1979 -344
☔ View full report in Codecov by Sentry. |
Hey @LucasXu0 can you help take a look at this? I'm not a fan of the implementation itself, maybe you have a better method in mind? |
I see two issues still here, what is your take on them:
Once we can merge this, I can continue work on AppFlowy to remove the title bar and abstract the share button and font settings out of the title bar as well. |
Will address the 2nd issue and then merge, to continue with the improvements on AppFlowy. |
- The toolbar would format the title node, which is not meant to happen. - Disabling the toolbar for the node ensures that it can't be turned into something else i.e list item.
…or into title_plugin
This plugin has been migrated from the AppFlowy repo
The original issue can be found here