refactor: use native contract functionality to perform lookups #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Note: this would serve both as an ENS conversion plugin, and also as an SDK for working with ENS contracts! |
fubuloubu
commented
Feb 14, 2022
| pass | ||
|
|
||
|
|
||
| def normalize_name(name: str) -> str: |
There was a problem hiding this comment.
Add note about copying from web3py, as well as using EIP-162 to design functionality.
antazoey
reviewed
Feb 22, 2022
|
|
||
| # NOTE: ENS Only references data from Ethereum Mainnet | ||
| registrar_deployment = list(ENS_PACKAGE.deployments.values())[0]["Registrar"] | ||
| with self.networks.ethereum.mainnet.use_provider( |
There was a problem hiding this comment.
If we are already connected to mainnet, we could just use the active provider and not have to make 2 connections
There was a problem hiding this comment.
Fair, although this seems like an optimization to make to the context manager
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #7
How I did it
How to verify it
Checklist