Skip to content

[IMP] #51 select for update on inputs avatars while creating operations #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[IMP] #51 select for update on inputs avatars while creating operations #52

wants to merge 8 commits into from

Conversation

petrus-v
Copy link

@petrus-v petrus-v commented Mar 9, 2022

petrus-v added 8 commits July 2, 2021 09:45
@petrus-v
ensure CI passed freezing lib as last run
1ebaa39
@petrus-v
bump to earlier working version without changes
27c22af
@petrus-v
fix test to bump anyblok versoin from <1.0.0 to <1.1.0
b7df6a0
@petrus-v
bump anyblok version < 1.2.0
defddf0
@petrus-v
be kind allowing earlier alembic/sqlalchemy version
b514327
@petrus-v
use latest alembic version
ee8b1ea
@petrus-v
[IMP] AnyBlok#51 select for update on inputs avatars while creating o…
fc4271e 
…perations

Issue was at least true while creating operation on the fly
(I think this could happen also in case of preparing operations)
If two concurrent request concurrently try to unpack the same
physobj this is resulting in two unpacked operation from the
same PhysObj which is making extrat duplicated PhysObj.

This also impact other operations as well for instance
in assembly if two request try to consume same physobj concurrently
as before this commit (using done at creation) whould result
in 2 physobj created from the same physobj
@petrus-v
[IMP] AnyBlok#51: add concurrency test for assembly operation
b3979b4
@petrus-v petrus-v mentioned this pull request Mar 9, 2022
Open
@petrus-v
Copy link
Author

petrus-v commented Apr 6, 2022

tips ! in production server don't forget to set the right isolation level in your app.cfg likes isolation_level=REPEATABLE_READ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@petrus-v