Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for yabsnap snapshot information #318

Merged
merged 6 commits into from
Mar 6, 2024
Merged

add support for yabsnap snapshot information #318

merged 6 commits into from
Mar 6, 2024

Conversation

64-bitman
Copy link
Contributor

@64-bitman 64-bitman commented Feb 19, 2024

Yabsnap is equivalent to OpenSUSE's snapper but made for Arch Linux

This PR adds support for parsing the information from the json metadata files that yabsnap uses to track comments and triggers (type). There is no set name for the metadata files, its just the name of the snapshot + "-meta.json", and the files are located in the same directory where its respective snapshot lives

@Schievel1
Copy link
Collaborator

Schievel1 commented Feb 19, 2024

Could you also edit the Readme a bit and mention this new program we support? Have you also tested how grub-btfsd behaves with yabsnap? If it's the same like snapper, e.g. keeping all the snapshots in /.snapshots, or any other directory, that is just there and does not disappear, this should work right out of the box. Timeshift does a few very special things.

@64-bitman
Copy link
Contributor Author

64-bitman commented Feb 19, 2024

Have you also tested how grub-btfsd behaves with yabsnap?

Yes and it works fine on my end, its very similar to snapper

@64-bitman
Copy link
Contributor Author

I think this PR is ready now

@Schievel1 Schievel1 merged commit 346a986 into Antynea:master Mar 6, 2024
1 check passed
@Schievel1
Copy link
Collaborator

thank you very much for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants