Indexer: Error handling - Detecting off platform users #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolambo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greater than 20% of addresses that trade friend.tech keys are not registered with friend.tech as users thus have no metadata. These users will always return 404 errors when attempting to be synced by the indexer. This PR should significantly improve the performance of profile sync by decreasing the amount of requests to get metadata for these off platform accounts.
Example:
User: https://basescan.org/address/0xf3dbd92cd3669dbd041405bff47edfe26343ee8b
API response: https://prod-api.kosetto.com/users/0xf3dbd92cd3669dbd041405bff47edfe26343ee8b
This PR Adds error handling for the case: 404 'Address/User not found.' then updates the user accordingly. This will prevent unnecessary db reads and sleep times for a request that will always throw an error. This should also allow the indexer to populate new users metadata quicker.