Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fall back to module resolution when relative imports fail #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kherock
Copy link
Contributor

@kherock kherock commented Nov 18, 2021

Resolves #187. These changes enable developers to import sass by the same resolution logic that webpack's sass-loader uses.

@kherock kherock marked this pull request as ready for review January 16, 2022 05:16
@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #198 (3efaa44) into main (11fcf2d) will decrease coverage by 0.08%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   99.63%   99.54%   -0.09%     
==========================================
  Files          36       36              
  Lines        1083     1089       +6     
  Branches      318      319       +1     
==========================================
+ Hits         1079     1084       +5     
- Misses          4        5       +1     
Impacted Files Coverage Δ
src/loaders/sass/importer.ts 96.42% <95.00%> (-3.58%) ⬇️
src/utils/url.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11fcf2d...3efaa44. Read the comment docs.

@kherock
Copy link
Contributor Author

kherock commented Jan 16, 2022

@Anidetrix (awesome to see that you're back!) I just rebased this and would appreciate getting it in an upcoming release. The implementation here should be fully backwards-compatible.

@leximarie
Copy link

@Anidetrix This would be very helpful to get in a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support resolving Sass modules without ~ in url
2 participants