fix: position of named export in injected css #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to change the sourcemap inlining behaviour once this PR is accepted, but that might need a discussion. Currently, sourcemap is injected when whenever the css is injected or emited. With the css sourcemap now being passed generateBundle hook and appearing in the main js sourcemap, the inlining should only be done when user chooses to explicitly inline (and in that case not explicitly passing the map from transform hook). |
All named export are now placed at the end of the injected css code. This solves the issue of css sourcemap not being passed on to the generateBundle hook due to the css being replaced by invalid js.
|
@Anidetrix I have rebased the changes on top of main. Please consider this PR again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix long pending issue I had alluded in the discussion in issue #160.