Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support resolving Sass modules without ~ in url #187

Open
kherock opened this issue Aug 25, 2021 · 0 comments · May be fixed by #198
Open

Support resolving Sass modules without ~ in url #187

kherock opened this issue Aug 25, 2021 · 0 comments · May be fixed by #198

Comments

@kherock
Copy link
Contributor

kherock commented Aug 25, 2021 •
edited

sass-loader has been recommending against using ~ in URLs since v11. Since then, some sass projects I use have been dropping the ~, and I can't use them without writing my own importer. Writing an importer which matches the code in this project isn't a small undertaking. As far as I'm aware, the only code in question is here:

rollup-plugin-styles/src/loaders/sass/importer.ts

Line 21 in e09ac09

if (!isModule(url)) return null;

I think it would be better to expose this behavior as an option, but I think that implementation should be straightforward as well.
@kherock kherock changed the title Support resolving modules without ~ in url Support resolving Sass modules without ~ in url Aug 25, 2021
@kherock kherock linked a pull request Nov 18, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: fall back to module resolution when relative imports fail kherock/rollup-plugin-styles
1 participant
@kherock