Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to notifications. #118

Merged
merged 1 commit into from
Sep 15, 2019
Merged

Add more details to notifications. #118

merged 1 commit into from
Sep 15, 2019

Conversation

95ulisse
Copy link
Contributor

AniTrend Pull Request

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • You have followed our contributing guidelines
  • double-check your branch is based on develop and targets develop
  • Pull request has tests
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved
  • I did not commit files that are excluded in the .gitignore file (Happens if you stage files with Android Studio)

Description

Right now, the Android notification shows only the number of unread notifications, and does not provide any context on what those notifications are.

This PR adds a bit more info to the notification so that the user can see right from the drawer his latest notifications.

Note: this is a very simple and limited implementation, but it should be sufficient for its limited goal.

Motivation and Context

Being able to see the latest notifications without opening the app might be a useful feature, especially
for those users (like me) who keep the notifications around as a reminder.

How Has This Been Tested?

I personally tested this only on my Samsung S7 Edge.

Screenshots (if appropriate):

Collapsed notification:

Collapsed

Expanded notification:

Expanded

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

@wax911 wax911 added the enhancement Improves exiting functionality label Sep 15, 2019
@wax911
Copy link
Member

wax911 commented Sep 15, 2019

Thanks for the PR @95ulisse in future please make an issue first to avoid working on something that might be already in progress 😉 or in this case just comment on the related issue.

Besides that good work and thanks again 💯

Resolves: #92

@wax911 wax911 merged commit 948593a into AniTrend:develop Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves exiting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants