Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transform): allow non-usage of WeakRef in Module conditionally #71

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Apr 16, 2024

Motivation

This PR tries to address this issue conditionally when it occurs too frequently. This is not a proper fix but a work around at the cost of memory consumption.

Summary

This works by introducing a new feature flag useWeakRefInEval that is true by default. If someone wants, they can set it to false in their wyw-in-js config to disable the usage of WeakRef.

Test plan

I tested locally in a fairly moderate example Pigment CSS repo. I can add tests on guidance.

Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: d000257

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Anber Anber merged commit cd7b7f0 into Anber:main Apr 16, 2024
4 checks passed
@Anber
Copy link
Owner

Anber commented Apr 16, 2024

Thank you @brijeshb42!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants