Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Fahrenheit in the weather block #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for Fahrenheit in the weather block #28

wants to merge 2 commits into from

Conversation

cashweaver-zz
Copy link

I've extended the weather block and simplified the switch to Fahrenheit. Celsius is still enabled by default.

vKnmnn
vKnmnn requested changes Feb 20, 2020
View reviewed changes
Copy link
Collaborator

@vKnmnn vKnmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't change the default temperature thresholds to some values on a very unscientific scale ;)
please do add your defaults as URGENT_LOWER_FAHRENHEIT or something like that and add a config option to select metric or imperial system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vKnmnn vKnmnn vKnmnn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cashweaver-zz @vKnmnn @cashpw