Assume local timezone when unspecified #124
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of the Date constructor is changing in ECMAScript 6: Date strings that do not specify a time zone will be interpreted in the local time (and not as GMT). This will cause Ampersand State's built-in
date
data type to behave inconsistently across platforms.This patch ensures consistency by explicitly interpreting Date strings without a time zone in the local system time in ECMAScript 5 environments. This should be considered a breaking change, which I recognize is a point against it. It would certainly be possible to avoid the break by instead patching the
date
data type to maintain its current behavior in ES6 environments, but I think that would be a nearsighted solution for two reasons:Date
constructor behavior and come to expect it from abstractions that use it.Commit message: