Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cascading from main to 12.0.0-next #2771

Merged
merged 44 commits into from
Jan 31, 2025
Merged

cascading from main to 12.0.0-next #2771

merged 44 commits into from
Jan 31, 2025
+1,842 −768

Conversation

fpaul-1A
Copy link
Contributor

Proposed change

Related issues

- No issue associated -

fpaul-1A and others added 30 commits January 24, 2025 09:12
@fpaul-1A
feat(chrome-devtools): add a panel to see the current value of all av…
fd8945b 
…ailable facts
@vscaiceanu-1a
fix: o3r/pipeline as dev dep
99b3ad0
@kpanot
fix(workspace): the tsconfig links to generate libraries
c4bfafb
@kpanot
fix(workspace): the tsconfig links to generate libraries (#2648)
e77dc8f 
## Proposed change

fix(workspace): the tsconfig links to generate libraries

It fixes the following points:
- generate the tsconfig.build.json (mandatory for lib standalone
publishing)
- remove the `dist/` path from the `tsconfig.base.json` which is leading
to wrong path mapping when the library was locally built
- register properly the lib in both tsconfig files
- update the tsconfig.lib.prod.json to extend the correct tsconfig

<!--
Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
-->

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

<!-- * 🐛 Fix #issue -->
* 🐛 Fix resolves #2665
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@renovate
chore(deps): lock file maintenance
def84fd
@kpanot
fix(workspace): update nx scope in generated executors
721f076
@kpanot
chore: ignore petstore basepath link
a6f7059
@kpanot
chore(deps): lock file maintenance (main) (#2733)
0799d0e 
This PR contains the following updates:

| Update | Change |
|---|---|
| lockFileMaintenance | All locks refreshed |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

🔧 This Pull Request updates lock files to use the latest dependency
versions.

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on monday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config
help](https://redirect.github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/AmadeusITGroup/otter).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjM5LjEyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->
@vscaiceanu-1a
fix: dev install for @o3r/pipeline (#2726)
a43450f 
## Proposed change

The `pipeline` package should be added as a dev dependency.

We should reflect if this is the case for other packages as well.
@kpanot
chore: ignore petstore basepath link (#2734)
0f9572b 
## Proposed change

chore: ignore petstore basepath link

<!--
Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
-->

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

* 🐛 Fix #2684
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@cpaulve-1A
fix: the tsconfig spec generated for library contains several issues
bb7adce 
Only use composite for library generated for workspace set up with jest.

Ensure path do not target any invalid files.
@cpaulve-1A
fix: the tsconfig spec generated for library contains several issues (#…
f507b87 
…2584)

## Proposed change

Only use composite for library generated for workspace set up with jest.
Ensure path do not target any invalid files.

## Related issues

* 🐛 Fix #2481
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@kpanot
fix(workspace): update nx scope in generated executors (#2717)
5bf474a 
## Proposed change

fix(workspace): update nx scope in generated executors

<!--
Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
-->

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@kpanot
fix: add missing files in workspace
455a383
@kpanot
fix(workspace-helpers): report deprecates npmjs url
f0b2032
@kpanot
fix: add missing files in workspace (#2682)
2f5ea93 
## Proposed change

fix: add missing files in workspace

<!--
Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
-->

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

<!-- * 🐛 Fix #issue -->
* 🐛 Fix resolves #2663
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@kpanot
fix(workspace-helpers): report deprecates npmjs url (#2744)
7e41c3b 
## Proposed change

fix(workspace-helpers): report deprecates npmjs url

<!--
Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
-->

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@kpanot
feat(design): add support of URL as token file input
b114f20
@kpanot
feat(design): add support of URL as token file input (#2745)
beda44b 
## Proposed change

feat(design): add support of URL as token file input

<!--
Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
-->

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@kpanot
fix(workspace): add husky in dev workspace dependency
ddb30ab
@kpanot
fix(workspace): add husky in dev workspace dependency (#2751)
72e90a8 
## Proposed change

fix(workspace): add husky in dev workspace dependency

<!--
Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
-->

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@fpaul-1A
feat(chrome-devtools): add a panel to see the current value of all av…
8d5863a 
…ailable facts (#2685)

## Proposed change

![image](https://github.com/user-attachments/assets/479d0f2d-5978-481f-a162-4710b7f8b969)

![image](https://github.com/user-attachments/assets/d92e3a70-5304-47dd-94a0-3a1b6e9c26fc)

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
* 🚀 Feature resolves #2476
<!-- * :octocat: Pull Request #issue -->
@vscaiceanu-1a
fix: build builders and schematics for o3r lib
cabfaae
@kpanot
fix(workspace): enforce husky install
efdce7e
@fpaul-1A
fix(github-actions): undeterministic github actions packaging
ab9dbdd
@vscaiceanu-1a
fix: build builder and schematics for o3r lib (#2727)
fe2bf4c 
## Proposed change

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
* 🐛 Fix resolves #2714
* 🐛 Fix resolves #2715
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@kpanot
fix(schematics): fix skip install task
7233bed 
fix(workspace): enforce install when pre-commit requested
@fpaul-1A
fix(github-actions): undeterministic github actions packaging (#2737)
2a68b9a 
## Proposed change

<!--
Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
-->

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@kpanot
Merge branch 'main' into bugfix/post-install-taskl
d8edee5
@fpaul-1A
chore: upgrade playwright 1.50
69bb7c3
@fpaul-1A fpaul-1A requested a review from a team as a code owner January 31, 2025 08:09
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 31, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 15c2183.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 1h 4m 12s View ↗
nx run-many --target=test-e2e ✅ Succeeded 8m 41s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 34s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 1m 15s View ↗
nx affected --target=lint ✅ Succeeded 15m 26s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 11m 14s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 12m 43s View ↗
Additional runs (2) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-31 09:41:43 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 66.24%. Comparing base (0815bc1) to head (15c2183).
Report is 45 commits behind head on release/12.0.0-next.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...o3r/workspace/schematics/library/rules/rules.ng.ts 76.19% 9 Missing and 1 partial ⚠️
...hematics/src/tasks/package-manager/npm-node-run.ts 92.30% 0 Missing and 1 partial ⚠️
...o3r/workspace/schematics/library/rules/rules.nx.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fpaul-1A fpaul-1A enabled auto-merge January 31, 2025 09:24
@fpaul-1A fpaul-1A merged commit e0e646b into release/12.0.0-next Jan 31, 2025
29 checks passed
@fpaul-1A fpaul-1A deleted the cascading/12.0-next-main branch January 31, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpanot kpanot

@mrednic-1A mrednic-1A

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request project:@ama-sdk/schematics project:audit-gh-action project:cascading-gh-action project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/chrome-devtools project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/design project:@o3r/eslint-config project:@o3r/extractors project:@o3r/pipeline project:@o3r/rules-engine project:@o3r/schematics project:@o3r/showcase project:@o3r/testing project:@o3r/workspace project:@o3r/workspace-helpers project:release-gh-action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fpaul-1A @kpanot @mrednic-1A @vscaiceanu-1a @cpaulve-1A @matthieu-crouzet