Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retrofit from main to 11.6.0-rc #2761

Merged
merged 3 commits into from
Jan 30, 2025
Merged

retrofit from main to 11.6.0-rc #2761

merged 3 commits into from
Jan 30, 2025

Conversation

fpaul-1A
Copy link
Contributor

@fpaul-1A fpaul-1A commented Jan 30, 2025 •
edited
Loading

Proposed change

Retrofit changes from:
#2717
#2648
#2584

Related issues

- No issue associated -

@fpaul-1A fpaul-1A requested a review from a team as a code owner January 30, 2025 09:55
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bef98ab.

Command Status Duration Result
nx run-many --target=test-e2e ❌ Failed 2m 5s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-30 13:00:37 UTC

@github-actions github-actions bot added bug Something isn't working project:@o3r/workspace labels Jan 30, 2025
kpanot and others added 2 commits January 30, 2025 11:00
@kpanot @fpaul-1A
fix(workspace): the tsconfig links to generate libraries
8c532e5
@cpaulve-1A @fpaul-1A
fix: the tsconfig spec generated for library contains several issues
bef98ab 
Only use composite for library generated for workspace set up with jest.

Ensure path do not target any invalid files.
@fpaul-1A fpaul-1A changed the title fix(workspace): update nx scope in generated executors retrofit from main to 11.6.0-rc Jan 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.03%. Comparing base (0bf643c) to head (bef98ab).
Report is 4 commits behind head on release/11.6.0-rc.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...o3r/workspace/schematics/library/rules/rules.ng.ts 76.19% 9 Missing and 1 partial ⚠️
...o3r/workspace/schematics/library/rules/rules.nx.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fpaul-1A fpaul-1A merged commit f37e43c into release/11.6.0-rc Jan 30, 2025
35 of 36 checks passed
@fpaul-1A fpaul-1A deleted the retrofit/2717 branch January 30, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrednic-1A mrednic-1A mrednic-1A approved these changes

@matthieu-crouzet matthieu-crouzet matthieu-crouzet approved these changes

Assignees
No one assigned
Labels
bug Something isn't working project:@o3r/components project:@o3r/configuration project:@o3r/eslint-config project:@o3r/testing project:@o3r/workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fpaul-1A @matthieu-crouzet @mrednic-1A @kpanot @cpaulve-1A