Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workspace-helpers): include build-swagger in yarn build command #2760

Merged
merged 1 commit into from
Jan 30, 2025
Merged

feat(workspace-helpers): include build-swagger in yarn build command #2760

merged 1 commit into from
Jan 30, 2025

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Jan 30, 2025 •
edited
Loading

Proposed change

feat(workspace-helpers): include build-swagger in yarn build command

Related issues

@kpanot kpanot requested a review from a team as a code owner January 30, 2025 03:42
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 146e055.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 57m 20s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 9m 29s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 36s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 1m 16s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 17m 14s View ↗
nx affected --target=lint ✅ Succeeded 14m 11s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 10m 7s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-30 15:34:45 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.88%. Comparing base (a94b143) to head (146e055).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpanot kpanot force-pushed the feature/build-mutualization branch 4 times, most recently from a455319 to b4c037f Compare January 30, 2025 05:52
@kpanot kpanot marked this pull request as draft January 30, 2025 06:15
@kpanot kpanot force-pushed the feature/build-mutualization branch from b4c037f to 7a3ccff Compare January 30, 2025 06:30
@kpanot kpanot marked this pull request as ready for review January 30, 2025 07:32
@kpanot kpanot force-pushed the feature/build-mutualization branch from 7a3ccff to 54a08a3 Compare January 30, 2025 07:57
fpaul-1A
fpaul-1A previously approved these changes Jan 30, 2025
View reviewed changes
mrednic-1A
mrednic-1A previously approved these changes Jan 30, 2025
View reviewed changes
sdo-1A
sdo-1A reviewed Jan 30, 2025
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
tools/@o3r/workspace-helpers/scripts/get-build-targets.mjs Outdated Show resolved Hide resolved
tools/@o3r/workspace-helpers/scripts/get-build-targets.mjs Outdated Show resolved Hide resolved
@kpanot kpanot dismissed stale reviews from mrednic-1A and fpaul-1A via 146e055 January 30, 2025 13:15
@kpanot kpanot force-pushed the feature/build-mutualization branch from 54a08a3 to 146e055 Compare January 30, 2025 13:15
@kpanot kpanot added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 3476f1b Jan 30, 2025
37 checks passed
@kpanot kpanot deleted the feature/build-mutualization branch January 30, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdo-1A sdo-1A sdo-1A approved these changes

@fpaul-1A fpaul-1A fpaul-1A approved these changes

@vscaiceanu-1a vscaiceanu-1a vscaiceanu-1a approved these changes

@mrednic-1A mrednic-1A mrednic-1A left review comments

Assignees
No one assigned
Labels
enhancement New feature or request project:@ama-sdk/schematics project:@o3r/workspace-helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Run build:swagger-gen automagically if JAVA is present on environment
5 participants
@kpanot @vscaiceanu-1a @mrednic-1A @fpaul-1A @sdo-1A