fix: improve performance of styling extractor #2586
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -219,7 +233,7 @@ export class CssVariableExtractor { | |||
| } | |||
|
|
|||
| let parsedValue: string | undefined; | |||
| if (varValue instanceof SassString || varValue instanceof SassNumber || varValue instanceof SassBoolean) { | |||
| if (varValue instanceof SassString || varValue instanceof SassNumber) { | |||
There was a problem hiding this comment.
To double check as well, was causing an issue with SassBoolean being undefined.
kpanot
reviewed
Dec 12, 2024
guillaumerochelle
force-pushed
the
bugfix/slow-extract-styling
branch
from
76dbe22 to
4c245d7
Compare
kpanot
reviewed
Dec 13, 2024
guillaumerochelle
force-pushed
the
bugfix/slow-extract-styling
branch
from
4c245d7 to
4a92e89
Compare
|
Waiting for issue resolution sass/embedded-host-node#358 |
guillaumerochelle
force-pushed
the
bugfix/slow-extract-styling
branch
6 times, most recently
from
ca91370 to
8861ed2
Compare
|
View your CI Pipeline Execution ↗ for commit c24ca1e.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
guillaumerochelle
force-pushed
the
bugfix/slow-extract-styling
branch
from
8861ed2 to
c24ca1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Switch to sass-embedded package to use Dart Sass CLI, instead of sass package.
From my first tests, it seems the time it takes to extract styling variables is divided by 10.
Related issues