Skip to content

fix(slider): Add overlapping based on the label width #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MarkoOleksiyenko
Copy link
Contributor

No description provided.

@MarkoOleksiyenko MarkoOleksiyenko linked an issue Mar 27, 2025 that may be closed by this pull request
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.26%. Comparing base (cfa39b5) to head (c0c19cf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/src/components/slider/slider.ts 92.30% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
- Coverage   91.30%   91.26%   -0.04%     
==========================================
  Files         109      109              
  Lines        3047     3081      +34     
  Branches      486      498      +12     
==========================================
+ Hits         2782     2812      +30     
  Misses        170      170              
- Partials       95       99       +4     
Flag Coverage Δ
e2e 83.01% <92.30%> (+0.05%) ⬆️
unit 84.47% <84.61%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MarkoOleksiyenko MarkoOleksiyenko force-pushed the slider-overlap branch 9 times, most recently from 0e12020 to 5851bfa Compare March 31, 2025 17:03
@MarkoOleksiyenko MarkoOleksiyenko marked this pull request as ready for review March 31, 2025 17:58
@quentinderoubaix quentinderoubaix added this to the v0.8 milestone Apr 1, 2025
@quentinderoubaix quentinderoubaix added bug Something isn't working widget: slider labels Apr 1, 2025
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @MarkoOleksiyenko, thx for the fix !

@quentinderoubaix quentinderoubaix merged commit 4fd868c into AmadeusITGroup:main Apr 1, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working widget: slider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider range display
2 participants