Release BlockReader in CRC check #18695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccy00808
reviewed
Sep 12, 2024
|
|
||
| // internal session id base should be smaller than all predefined session ids | ||
| public static final long INTERNAL_SESSION_ID_BASE = -8; |
There was a problem hiding this comment.
why change this value, can we set independent name？ eg: CRC_CHECK_SESSION_ID
ccy00808
approved these changes
Sep 12, 2024
|
alluxio-bot, merge this please. |
|
alluxio-bot, cherry-pick this to branch-2.10 please. |
alluxio-bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
### What changes are proposed in this pull request? Please outline the changes and how this PR fixes the issue. ### Why are the changes needed? Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, describe the bug. ### Does this PR introduce any user facing changes? Please list the user-facing changes introduced by your change, including 1. change in user-facing APIs 2. addition or removal of property keys 3. webui pr-link: #18695 change-id: cid-fba7d00da83719d31df0d917e1419ed049adeed8
|
Auto cherry-pick to branch |
alluxio-bot
added a commit
that referenced
this pull request
Sep 12, 2024
Cherry-pick of existing commit. orig-pr: #18695 orig-commit: c0cea82 orig-commit-author: elega <[email protected]> pr-link: #18696 change-id: cid-fba7d00da83719d31df0d917e1419ed049adeed8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including