Added Filter to ComboWidget #950
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gucio321
reviewed
Mar 19, 2025
Widgets.go
Outdated
| filter.Clear() | ||
| } | ||
|
|
||
| filter.DrawV("##Filter", -1) |
There was a problem hiding this comment.
I think this might result in some strange behaviours when multiple things with this tag are drawn. Maybe use GenAutoID here.
gucio321
reviewed
Mar 20, 2025
| @@ -201,6 +205,9 @@ func Combo(label, previewValue string, items []string, selected *int32) *ComboWi | |||
| selected: selected, | |||
| flags: 0, | |||
| width: 0, | |||
| filter: false, | |||
| filterWidget: imgui.NewEmptyTextFilter(), | |||
| filterLabel: GenAutoID(""), | |||
There was a problem hiding this comment.
I'd use GenAutoID("filter") (because of internal mechanisms of GenAutoID this will reduce potential issues)
There was a problem hiding this comment.
Well, this makes the popup just rapidly grow for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In examples/imguidemo, there is a combo box with a filter. It sadly doesn't seem to exist currently, creating quite a false-promise. So, I went to the original imgui repo and took the code from there to create a
Filtermethod on theComboWidget, specifying if there should be a TextFilter when opening it.