-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assistants page #559
base: main
Are you sure you want to change the base?
Assistants page #559
Conversation
I'm curious, what's your motivation for this change? You don't like that going to the root url takes you straight to an assistant? I'm not opposed to the change. Other people might prefer this mode. But personally, if I have a quick question and I pull up my app, I don't like the extra click before I can start typing the question. So seeing this change just made me wonder if there was an issue you were trying to solve because it might spark new thinking for me. |
I was exploring what might be possible if each assistant (or "agent" as it might be known elsewhere) had some room to breath on the page; and perhaps go further to exposing the idea that these assistants aren't just "gpt-4o" or "claude-3.5" but pre-configured system prompts (plus more perhaps one day). The idea for the page came from seeing the magicschool.ai home page (which calls them Tools). The PR is disabled by default; requiring the feature flag/env var. It's ok if you don't want to merge it. It was an idea I was working on and figured I could share it publicly as a PR. |
Oh, that’s intriguing. The other cool thing about a page like this is when Teams are an entity in the system, this could also be where you see that it’s a private assistant or a team assistant. For example, maybe you’re part of a team which has created a Tech Support assistant which has a custom system prompt and has specific knowledge of how your company’s internal systems are configured and how to access those systems. This page would show a description of all that, make it clear that it’s a Team Assistant, and it also makes it clear that any conversations you have with this assistant are visible to the owner of that assistant. It’s like “this conversation is being recorded for quality assurance purposes” :) I like this. Let’s merge it in and leave it behind a feature flag, just like you did, while we continue to develop this concept. But three things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I just realized I didn't submit the comment I had written:
<section | ||
id="assistants" | ||
data-controller="radio-behavior transition" | ||
data-radio-behavior-selected-class="relationship !flex" | ||
data-transition-toggle-class="hidden" | ||
class="pt-14 flex flex-col" | ||
class="flex flex-col" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you removed this pt-14 and you within the _assistant_sidebar partial, you removed the first
hack:
<%= first && 'absolute pt-[17px] left-0 pl-3 w-full z-10 top-0' %>
I remember this being some tricky css to get the sidebar to make the first assistant sticky as the other items scrolled underneath it. Were you able to solve it a different way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think this idea was getting in my way (since I wanted an "Assistants" header as the first thing) so I dropped it and assumed I'd come back to it later. I'll investigate this.
|
ebb86de
to
d5adddd
Compare
@buithehien1991 I am unsure how to reproduce your bug sorry. To confirm, this bug only appeared when you switched to this PR's branch? When you switched back to |
@krschacht I've rejiggered the sidebar so:
I've also reverted the partial names. |
I also get that P.S. It's strange because if I start the server and initiate a new conversion and ask 1 message before clicking on any of the old conversations, everything works fine. |
Feature flag
ASSISTANTS_PAGE_FEATURE=true
introduces a simple page showing the available Assistants.When this feature is enabled, the
root_path
andassistants_path
show this page (instead of redirecting to a new conversation with a default assistant):This PR also includes a default description for each default Assistant.