Add a smart default_to method in our options.yml #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The system tests have been having trouble. Initially I thought there may be a flaky test. But I re-ran and they just hung forever so now i’m hoping this is just an issue with github’s servers. Trying a third time. |
jlvallelonga
approved these changes
Aug 1, 2024
|
Merged |
krschacht
added a commit
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within config.yml we can now do:
This means that it will fall back to the value within default_to() except when it's in the test environment. And the value within default_to gets smartly looked up in the credentials file if it's a single symbol or a hash.