Changes in Footer Contents Alignment and Hover Effects #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravikr126
approved these changes
May 16, 2021
harikesh409
requested changes
May 16, 2021
| @@ -815,6 +815,10 @@ HEAD .round-2 { | |||
| .box { | |||
| margin-bottom: 20px; | |||
| } | |||
| .container | |||
| { | |||
| flex-direction: column; | |||
There was a problem hiding this comment.
Why changing the flex-direction?
There was a problem hiding this comment.
Sir I thought it will make it responsive like in mobile size it will come to center. All other issues i have resolved today. Only this responsive issue is left to be resolved which I will complete soon...
| <h5 class="font-weight-bold text-white mb-lg-4 pb-2 margin-top-mobile">Useful Links</h5> | ||
| <ul> | ||
| <li> | ||
| <a class="text-white mb-lg-3" href="#about">About</a> | ||
| </li> | ||
| <hr style="margin-right: 40%;"> |
There was a problem hiding this comment.
These hr's look very weird.
| </ul> | ||
| </div> | ||
|
|
||
| <div class="col-lg-3 col-md-3 col-sm-6 col-12"> | ||
| <div class="center col-lg-4.5 col-md-3 col-sm-6 col-12"> |
There was a problem hiding this comment.
There are no classes center and col-lg-4.5 either in bootstrap or in custom styles.
| </ul> | ||
| </div> | ||
|
|
||
| <div class="col-lg-3 col-md-3 col-sm-6 col-12 socialicons"> | ||
| <div class="col-lg-4.5 col-md-3 col-sm-6 col-12 socialicons"> |
There was a problem hiding this comment.
col-lg-4.5 is an invalid class.
|
Moved to #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed.
Fixes
->The logo and para tag which was at the bottom is shifted at the top of footer container.
->Aligned the content to the center.
->Aligned the contact us and email bar one below the other from side by side.
->a single line of code to make it responsive for mobile view.
->Changed color of hovering.
->Added hr tags below the content.
#119
List any dependencies that are required for this change
Type of change
#Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Yes I have tested it on my laptop.
UI /UX changes
Attach gif or screenshot for changes.
- After : Pic of Foter after changes has been uploaded in the link below.
- https://drive.google.com/file/d/1DoV1gAt2E53es37OsymjkUZbmiSS73XF/view?usp=drivesdk
Checklist: