Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6645][ADW] Search Feature Stabilisation #9701

Merged
merged 4 commits into from
May 22, 2024

Conversation

tamaragruszka
Copy link
Contributor

@tamaragruszka tamaragruszka commented May 20, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
fields need to be set by input

What is the new behaviour?
if there is search configuration it overrides input fields

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@tamaragruszka tamaragruszka self-assigned this May 20, 2024
@DenysVuika DenysVuika changed the title [ACS-6645][ADW] Search Feature Stabilisatio [ACS-6645][ADW] Search Feature Stabilisation May 20, 2024
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@DenysVuika DenysVuika merged commit b8c8e5c into develop May 22, 2024
32 of 33 checks passed
@DenysVuika DenysVuika deleted the ACS-6645-ADW-Search-Feature-Stabilisation branch May 22, 2024 15:50
DaryaBalvanovich pushed a commit that referenced this pull request May 23, 2024
* [ACS-6645] override input fields

* [ACS-6645] update test and documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants