AAE-30358 Token is not refreshed in WS connection_init when changing pages #10781
+31
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alep85
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
alep85
requested review from
VitoAlbano,
ehsan-2019,
eromano,
andrea-ligios and
DiogoABastos
and removed request for
DenysVuika,
eromano and
popovicsandras
ehsan-2019
reviewed
Apr 10, 2025
| @@ -155,10 +160,13 @@ export class WebSocketService { | |||
| this.wsLink = new GraphQLWsLink( | |||
| createClient({ | |||
| url: this.createWsUrl(options.wsUrl) + '/v2/ws/graphql', | |||
| connectionParams: { | |||
| connectionParams: () => ({ | |||
ehsan-2019
approved these changes
Apr 10, 2025
…o use the refreshed token changing the page, turn connectionParams into a function to ensures that the latest token is always used for WebSocket connections
…ql return unauthorized error
alep85
force-pushed
the
fix/AAE-30358-ws-token-is-not-refreshed-in-ws-connection-init-when-changing-pages
branch
from
18322fd to
10346db
Compare
|
VitoAlbano
reviewed
Apr 23, 2025
| return false; | ||
| } | ||
|
|
||
| const isUnauthorizedError = |
There was a problem hiding this comment.
I think we can reuse this part to actually catch the error from network when it happens and then try to refresh the token. Same with the retry mechanism instead of having a plain number we can use the retryIf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-30358
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: