Accept rtsp client without interleaved parameter #1511

fmcloudconsulting · 2024-12-16T21:52:43Z

AlexxIT · 2024-12-17T13:08:37Z

Your changes are incorrect. The client can come for UDP transport.

fmcloudconsulting · 2024-12-17T15:12:47Z

The existing code already expects TCP-only transport, so there is no regression with this PR?

AlexxIT · 2024-12-17T15:49:44Z

But it return 461 Unsupported transport error, so smart client can change UDP to TCP request. Many clients support this out of box.

fmcloudconsulting · 2024-12-17T16:37:51Z

Got the point. Should be fixed now.

AlexxIT · 2024-12-17T17:54:25Z

It's wrong again. Some clients don't send unicast word. I think only first prefix should be enough.

fmcloudconsulting · 2024-12-17T18:07:10Z

Fixed.
By the way, there was a typo between tr and transport variables, fixed!
I'll build & deploy on my side.

feat: accept rtsp client without interleaved parameter

29f7f1a

AlexxIT added the invalid This doesn't seem right label Dec 17, 2024

fmcloudconsulting added 3 commits December 17, 2024 17:28

fix: return 461 if client requested an invalid transport method

fd125ec

chore: lint

d881755

fix: typo

4b80b2c

fix: don't require unicast param and fix typo (tr instead of transport)

6fa352f

AlexxIT removed the invalid This doesn't seem right label Dec 18, 2024

AlexxIT self-assigned this Dec 18, 2024

Provide feedback