fix(mdns): macos: handle address reuse and fallback for no interfaces #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How can I replicate this error on my mac? I have go2rtc running with no errors. Without sudo. |
AlexxIT
added a commit
to skrashevich/go2rtc
that referenced
this pull request
Oct 15, 2025
AlexxIT
force-pushed
the
fix-multicast-macos
branch
from
15b54ae to
efb1ae1
Compare
AlexxIT
reviewed
Oct 15, 2025
| if err != nil { | ||
| return errors.New("no interfaces for listen and fallback failed: " + err.Error()) | ||
| } | ||
| b.Sends = append(b.Sends, conn) |
There was a problem hiding this comment.
This won't work. We need networks. They are used further in the logic.
AlexxIT
reviewed
Oct 15, 2025
| conn, err := lc1.ListenPacket(ctx, "udp4", ipn.IP.String()+":5353") // same port important | ||
| if err != nil { | ||
| if strings.Contains(err.Error(), "address already in use") { | ||
| continue |
AlexxIT
reviewed
Oct 15, 2025
| return | ||
| } | ||
|
|
||
| func InterfacesIP4() ([]net.IP, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the error
ERR internal/homekit/homekit.go:128 > error="no interfaces for listen"on macOS when running the application without root privileges.Problem
The mDNS client was failing to bind to network interfaces, resulting in the error mentioned above. This typically occurred when specific network interfaces were not available or the address was already in use.
Solution
Address Reuse Handling:
Fallback for No Interfaces:
Impact
These changes ensure that the mDNS client can gracefully handle common networking issues on macOS, improving reliability when the application is run without root privileges.
Fixes #1225