Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Republic of Korea BandPlan #1501

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Conversation

bsy0318
Copy link
Contributor

@bsy0318 bsy0318 commented Oct 22, 2024

Add Republic of Korea BandPlan.
It's not the Democratic People's Republic of Korea!

Add Republic of Korea BandPlan.
It's not the Democratic People's Republic of Korea!
@AlexandreRouma
Copy link
Owner

AlexandreRouma commented Oct 22, 2024

SDR++ doesn't support displaying characters outside the latin alphabet so the bandplan won't display properly. This needs to be translated to english. Also there are some typos in the band types (eg. marin instead of marine)

@bsy0318
Copy link
Contributor Author

bsy0318 commented Oct 22, 2024

Hello! I've made the requested changes and submitted a pull request. Please review it. :)

@AlexandreRouma
Copy link
Owner

Alright, just one last thing. The indentation has to be 4 spaces like it was before.

Modify indentation
@bsy0318
Copy link
Contributor Author

bsy0318 commented Oct 22, 2024

Thank you for your quick response!
I've made the requested changes and submitted a pull request. Please review it. :)

@AlexandreRouma
Copy link
Owner

I'm finding more errors, some amateur bands have type "fixed" instead of "amateur"

@bsy0318
Copy link
Contributor Author

bsy0318 commented Oct 22, 2024

corrected that

@bsy0318
Copy link
Contributor Author

bsy0318 commented Oct 22, 2024

In addition, this is designated by the Korea Radio Administration Authority.

@AlexandreRouma AlexandreRouma merged commit 3982db7 into AlexandreRouma:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants